Skip to content

Commit

Permalink
Match PPG implementation (#186)
Browse files Browse the repository at this point in the history
* added nit changes from ppg code

* change observation buffer to uint8

* sample full rollouts

* minor device fix

* update optimizer settings

* add ppg documentation

* update mkdocs

* update images to png for codespell errors

* trigger CI

* Minor format change

* format by running `pre-commit`

* removes trailing space

* Add an extra note

* argument names and documentation changes

* add capture video

* add experiment report

* Update documentation

* Quick css fix

* Update documentation

* Fix documentation for PPO

* Add benchmark commands

* Add benchmark commands

* add metrics section

* Add more docs

* Quick fix on ddpg docs

* Add procgen test cases

* Update CI

* test CI

* test ci

* Update tests

* normalization axis documentation

Co-authored-by: Dipam Chakraborty <dipam@aicrowd.com>
Co-authored-by: Costa Huang <costa.huang@outlook.com>
  • Loading branch information
3 people authored May 28, 2022
1 parent ab1c22f commit eba6452
Show file tree
Hide file tree
Showing 18 changed files with 696 additions and 11 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: pre-commit

on:
push:
branches: [ master ]
pull_request:
branches: [ '*' ]
branches: [ master ]
jobs:
build:
runs-on: ubuntu-latest
Expand Down
31 changes: 31 additions & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ on:
- '**/README.md'
- 'docs/**/*'
- 'cloud/**/*'
pull_request:
paths-ignore:
- '**/README.md'
- 'docs/**/*'
- 'cloud/**/*'
jobs:
test-core-envs:
strategy:
Expand Down Expand Up @@ -88,6 +93,32 @@ jobs:
- name: Run pybullet tests
run: poetry run pytest tests/test_pybullet.py

test-procgen-envs:
strategy:
fail-fast: false
matrix:
python-version: [3.8]
poetry-version: [1.1.11]
os: [ubuntu-18.04, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Run image
uses: abatilo/actions-poetry@v2.0.0
with:
poetry-version: ${{ matrix.poetry-version }}

# procgen tests
- name: Install core dependencies
run: poetry install -E "pytest procgen"
- name: Downgrade setuptools
run: poetry run pip install setuptools==59.5.0
- name: Run pybullet tests
run: poetry run pytest tests/test_procgen.py


test-mujoco-envs:
strategy:
Expand Down
8 changes: 8 additions & 0 deletions benchmark/ppg.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# export WANDB_ENTITY=openrlbenchmark

poetry install -E procgen
xvfb-run -a python -m cleanrl_utils.benchmark \
--env-ids starpilot bossfight bigfish \
--command "poetry run python cleanrl/ppg_procgen.py --track --capture-video" \
--num-seeds 3 \
--workers 1
3 changes: 0 additions & 3 deletions cleanrl/ddpg_continuous_action.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
# docs and experiment results can be found at https://docs.cleanrl.dev/rl-algorithms/ddpg/#ddpg_continuous_actionpy
# docs and experiment results can be found at
# https://docs.cleanrl.dev/rl-algorithms/ddpg/#ddpg_continuous_actionpy

import argparse
import os
import random
Expand Down
Loading

1 comment on commit eba6452

@vercel
Copy link

@vercel vercel bot commented on eba6452 May 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

cleanrl – ./

cleanrl.vercel.app
cleanrl-git-master-vwxyzjn.vercel.app
docs.cleanrl.dev
cleanrl-vwxyzjn.vercel.app

Please sign in to comment.