-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for dqn.py
#157
Add docs for dqn.py
#157
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/AuRtE9dc44G88RDWW5CapYTxT3Pe |
3d593df
to
22fb0f7
Compare
This PR is ready for review. |
Additional note: I realized it would be pretty hard to run benchmark experiments based on some master's version. From now on, we should do something like
in the reproducibility instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good over here too.
I noticed there is no dqn_atari.py benchmarks in the docs though. Will it be alright ?
The |
Let me know if this addresses your concern :) |
Description
This PR adds documentation for
dqn.py
and couple documentation fixes fordqn_atari.py
Types of changes
Checklist:
pre-commit run --all-files
passes (required).mkdocs serve
.If you are adding new algorithms or your change could result in performance difference, you may need to (re-)run tracked experiments. See #137 as an example PR.
--capture-video
flag toggled on (required).mkdocs serve
.width=500
andheight=300
).