Minor improvements over the last FileInputStream enhancement

vy · Oct 23, 2023 · 0fa934f · 0fa934f
1 parent 0a1b336
commit 0fa934f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,8 @@
 
 ### (????-??-??) v0.9.6
 
+- Avoid using `FileInputStream`, since it requires a full-GC for clean-up. (#174, #175)
+
 ### (2022-06-02) v0.9.5
 
 - Guard against I/O failures while reading file length. (#70)

diff --git a/README.md b/README.md
@@ -175,6 +175,7 @@ methods.
   thread-safety improvements)
 - [Lukas Bradley](https://github.com/lukasbradley/)
 - [Liran Mendelovich](https://github.com/liran2000/) (rolling via `maxBackupCount`)
+- [Nicolas Clemeur](https://github.com/nclemeur) (avoiding `FileInputStream`)
 
 # License
 

diff --git a/src/main/java/com/vlkan/rfos/RotatingFileOutputStream.java b/src/main/java/com/vlkan/rfos/RotatingFileOutputStream.java
@@ -105,12 +105,14 @@ private void startPolicies() {
 
     private ByteCountingOutputStream open(RotationPolicy policy, Instant instant) {
         try {
-			OpenOption[] openOptions = { StandardOpenOption.CREATE,
-                    this.config.isAppend() ? StandardOpenOption.APPEND : StandardOpenOption.TRUNCATE_EXISTING };
-            OutputStream fileOutputStream = Files.newOutputStream(this.config.getFile().toPath(), openOptions);
-            invokeCallbacks(callback -> callback.onOpen(policy, instant, fileOutputStream));
+			OpenOption[] openOptions = {
+                    StandardOpenOption.CREATE,
+                    this.config.isAppend() ? StandardOpenOption.APPEND : StandardOpenOption.TRUNCATE_EXISTING
+            };
+            OutputStream outputStream = Files.newOutputStream(this.config.getFile().toPath(), openOptions);
+            invokeCallbacks(callback -> callback.onOpen(policy, instant, outputStream));
             long size = config.isAppend() ? readFileLength() : 0;
-            return new ByteCountingOutputStream(fileOutputStream, size);
+            return new ByteCountingOutputStream(outputStream, size);
         } catch (IOException error) {
             String message = String.format("file open failure {file=%s}", config.getFile());
             throw new RuntimeException(message, error);