Skip to content

Commit

Permalink
#11 Add explicit Java 9 module name.
Browse files Browse the repository at this point in the history
  • Loading branch information
vy committed Dec 8, 2019
1 parent 9f01524 commit 66f181e
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 2 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
### (????-??-??) v0.9.0
### (2019-12-08) v0.9.1

- Added explicit Java 9 module name. (#11)

### (2019-12-03) v0.9.0

- Switched to semantic versioning scheme. (#10)

Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ You first need to include `rotating-fos` in your Maven/Gradle dependencies:
</dependency>
```

(Note that the Java 9 module name is `com.vlkan.rfos`.)

`RotatingFileOutputStream` does not extend `java.io.FileOutputStream` (as a
deliberate design decision, see [How (not) to extend standard collection
classes](https://javachannel.org/posts/how-not-to-extend-standard-collection-classes/)),
Expand Down Expand Up @@ -128,7 +130,7 @@ methods.
# Contributors

- [Christoph (pitschr) Pitschmann](https://github.com/pitschr) (Windows-specific
fixes, `RotationCallback#onOpen()` method)
fixes, `RotationCallback#onOpen()` method, Java 9 module name)
- [Jonas (yawkat) Konrad](https://yawk.at/) (`RotatingFileOutputStream`
thread-safety improvements)
- [Lukas Bradley](https://github.com/lukasbradley/)
Expand Down
16 changes: 16 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@

<properties>

<!-- common properties -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.resourceEncoding>UTF-8</project.build.resourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>1.8</java.version>

Expand All @@ -70,6 +72,7 @@
<!-- plugin versions -->
<maven-compiler-plugin.version>3.6.1</maven-compiler-plugin.version>
<maven-gpg-plugin.version>1.6</maven-gpg-plugin.version>
<maven-jar-plugin.version>3.2.0</maven-jar-plugin.version>
<maven-javadoc-plugin.version>2.10.4</maven-javadoc-plugin.version>
<maven-release-plugin.version>2.5.3</maven-release-plugin.version>
<maven-source-plugin.version>3.0.1</maven-source-plugin.version>
Expand Down Expand Up @@ -141,6 +144,19 @@
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>${maven-jar-plugin.version}</version>
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>com.vlkan.rfos</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
</plugin>

</plugins>

</build>
Expand Down

0 comments on commit 66f181e

Please sign in to comment.