Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config-mgmt: T5976: commit-confirm completion to include soft revert #93

Merged
merged 1 commit into from
Oct 8, 2024
Merged

config-mgmt: T5976: commit-confirm completion to include soft revert #93

merged 1 commit into from
Oct 8, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Oct 8, 2024

Change Summary

Adjust completion hints to drop explicit reference to 'reboot', now that we have the option of 'soft' rollback.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):
    Completion hint.

Related Task(s)

Related PR(s)

vyos/vyos-1x#4128

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Oct 8, 2024
@jestabro jestabro requested a review from a team as a code owner October 8, 2024 16:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

👍
No issues in PR Title / Commit Title

@jestabro jestabro mentioned this pull request Oct 8, 2024
Merged
12 tasks
@jestabro jestabro merged commit 2f5045e into vyos:current Oct 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner automatically assigned from vyos/reviewers

Assignees

@jestabro jestabro

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jestabro @sever-sever @c-po