Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T4849: add Ten64/NXP DPAA2 support patches #288

Closed
wants to merge 3 commits into from
Closed

T4849: add Ten64/NXP DPAA2 support patches #288

wants to merge 3 commits into from

Conversation

mcbridematt
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://phabricator.vyos.net/T4849

Component(s) name

Proposed changes

Updates the arm64 kernel configuration to 5.15 (equivalent to the x86 version at the time of writing), as well as the image data for arm64 (correct GRUB + kernel package variants).
Additionally, patches to fix SFP+ issues on the Traverse Technologies Ten64 platform are included
(Note to self: To avoid breaking x86 in the future it could be a good idea to only apply these patches when target arch = arm64. I'll create a new task/pull if I get around to that)

How to test

This is part of the 'port' I have done over here: https://github.com/mcbridematt/vyos-arm64-builder . I am slowly iterating down my patchset (there are various other bits that still need to be addressed for a complete x86-equivalent build)
See here for more info: https://forum.traverse.com.au/t/vyos-build-my-repo/181/5 or in vyos-on-arm64 in the VyOS slack

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@MartB
Copy link

MartB commented Jan 26, 2023 •
edited
Loading

Another thing to note:
Im not sure where the original arm64 config came from.
There is quite an extensive non-architecture related list of differences compared to the x86 config in a few places.

Some examples are the CONFIG_TCP_CONG_*, CONFIG_IPV6_*, CONFIG_INET6_*, CONFIG_NETFILTER_ and CONFIG_NFT_ keys, to name a few network-related ones.

Would be wise to try and match these two configs where applicable.

Edit:
I uploaded the changes I had flying around for "reference" but i probably made a few mistakes anyway.
https://github.com/MartB/vyos-build/tree/current-arm64
https://github.com/MartB/vyos-arm64-builder

@mcbridematt
Copy link
Contributor Author

I think the original one in vyos-build came from a Raspberry Pi and is missing a lot of ARM server related options (like EFI and ACPI) as a result.

I took our (Traverse) standard config ( https://gitlab.com/traversetech/traverse-kernel-patches/-/blob/torvalds/kernel-config ) and tried to "equalize" the networking options with Vyos-x86 but it seems I missed a few, thanks for the hints!

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@mcbridematt mcbridematt marked this pull request as draft February 17, 2023 11:24
@c-po c-po added the current label Sep 15, 2023
tjjh89017 and others added 3 commits December 15, 2023 01:16
@tjjh89017 @mcbridematt
T5499: arm64: update vyos kernel configs with debian stock kernel
140aa2d 
Signed-off-by: Date Huang <tjjh89017@hotmail.com>
@tjjh89017 @mcbridematt
T5499: arm64: remove some kernel configs to speed up
df4364d 
Signed-off-by: Date Huang <tjjh89017@hotmail.com>
@mcbridematt
Kernel: T4849: add SFP patch for Traverse Ten64 / NXP DPAA2 platform
a424c69 
This patch set is imported from the series "Fix rtnl_mutex deadlock with
DPAA2 and SFP modules"[1] that landed in kernel 6.2.

[1] https://patchwork.kernel.org/project/netdevbpf/list/?series=700098&state=%2A&archive=both
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mcbridematt
Copy link
Contributor Author

I've just updated this on top of #421 (T5499).

There are no other kernel config changes needed on top of that. (There is an SMMU/IOMMU issue requiring a kernel cmdline addition, but I think I can fix the firmware to work without that)

The SFP related fixes for our platform (NXP DPAA2) landed in kernel 6.2, which I have squashed into a singular .patch.

@mcbridematt mcbridematt changed the title T4849: update arm64 kernel to 5.15.x / add Ten64 support T4849: add Ten64/NXP DPAA2 support patches Dec 15, 2023
@c-po
Copy link
Member

c-po commented Feb 9, 2024

Please rebase as #495 was merged

@c-po c-po added the stale PR has become inactive or needs attention label Feb 17, 2024
@c-po c-po requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever, c-po and MartB and removed request for a team and MartB February 17, 2024 19:48
@dmbaturin
Copy link
Member

Closing due to no response from the reporter in over a month. Please reopen it if/when you get the time to rebase it.

@dmbaturin dmbaturin closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartB MartB MartB left review comments

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

@c-po c-po Awaiting requested review from c-po c-po is a code owner automatically assigned from vyos/reviewers

Assignees

@mcbridematt mcbridematt

Labels
current stale PR has become inactive or needs attention
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcbridematt @MartB @c-po @dmbaturin @tjjh89017