pmacct: T5618: Added build rules for custom pmacct package (backport #428) #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of pmacct in Debian (`1.7.7-1`) contains the bug which leads to a crash when IMT is enabled and ICMP traffic is forwarded through a router. This commit adds our build with an extra patch, which solves the problem: pmacct/pmacct@73af954 (cherry picked from commit d5f6445)
(cherry picked from commit 3c313a6)
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro and
sever-sever
and removed request for
a team
sever-sever
approved these changes
Sep 29, 2023
Removed extra `not` in the `if` condition of the build script which inverts the return code. (cherry picked from commit 59e34c8)
sever-sever
approved these changes
Sep 29, 2023
sarthurdev
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added build rules for custom pmacct package
Backport of #428
Types of changes
Related Task(s)
Component(s) name
pmacct
Proposed changes
The current version of pmacct in Debian (
1.7.7-1) contains the bug which leads to a crash when IMT is enabled and ICMP traffic is forwarded through a router.This PR adds our build with an extra patch, which solves the problem: pmacct/pmacct@73af954
How to test
Configuration for tests:
Without the patched pmacct version, as soon as
eth0receives an ICMP packet pmacct will crash.Checklist: