Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6173: fix TypeError: 'NoneType' object is not iterable (backport #565) #566

Merged
merged 1 commit into from
Apr 13, 2024
Merged

T6173: fix TypeError: 'NoneType' object is not iterable (backport #565) #566

merged 1 commit into from
Apr 13, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 13, 2024

Change Summary

Commit 611cfc8 ("T6173: validate allowed characters in ISO image name") missed the probability that version is a dict member bot empty.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

./build-vyos-image iso --architecture amd64 --build-by "user@domain.net"

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #565 done by [Mergify](https://mergify.com).

@c-po @mergify
T6173: fix TypeError: 'NoneType' object is not iterable
48722ae 
Commit 611cfc8 ("T6173: validate allowed characters in ISO image name")
missed the probability that version is a dict member bot empty.

(cherry picked from commit 801def2)
@mergify mergify bot mentioned this pull request Apr 13, 2024
Merged
11 tasks
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 13, 2024 10:38
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 13, 2024
@c-po c-po merged commit 1504942 into sagitta Apr 13, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-565 branch April 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sever-sever @c-po