Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image-tools: T6154: installer prompts to confirm password #569

Merged
merged 1 commit into from
Apr 17, 2024
Merged

image-tools: T6154: installer prompts to confirm password #569

merged 1 commit into from
Apr 17, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Apr 16, 2024 •
edited
Loading

Change Summary

NOTE this must accompany vyos/vyos-1x#3321

Adjust scripts/check-qemu-install for added prompt.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Apr 16, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team April 16, 2024 18:29
@jestabro jestabro mentioned this pull request Apr 16, 2024
Merged
12 tasks
@jestabro jestabro marked this pull request as ready for review April 16, 2024 18:45
@vyosbot vyosbot requested a review from a team April 16, 2024 18:45
@sever-sever sever-sever merged commit 67511ae into vyos:current Apr 17, 2024
4 checks passed
@jestabro
Copy link
Contributor Author

@Mergifyio backport sagitta

@mergify Mergify
Copy link

mergify bot commented Apr 17, 2024 •
edited
Loading

backport sagitta

✅ Backports have been created

This was referenced Apr 17, 2024
Merged
Merged
jestabro added a commit that referenced this pull request Apr 17, 2024
@jestabro
Merge pull request #570 from vyos/mergify/bp/sagitta/pr-569
2607318 
image-tools: T6154: installer prompts to confirm password (backport #569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

Assignees

@jestabro jestabro

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jestabro @sever-sever @c-po