Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suricata: T751: Disable suricata.service by default #582

Merged
merged 1 commit into from
May 14, 2024

Conversation

0xThiebaut
Copy link
Contributor

Change Summary

Added initial support for Suricata (IDS):

  • Ensure Suricata is disabled by default.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

  • ids
  • suricata

Proposed changes

Disable the suricata service to ensure it does not run without passing through configuration validation.

How to test

On the build image, run systemctl status suricata.

○ suricata.service - Suricata IDS/IDP daemon
     Loaded: loaded (/lib/systemd/system/suricata.service; disabled; preset: enabled)
     Active: inactive (dead)
       Docs: man:suricata(8)
             man:suricatasc(8)
             https://suricata-ids.org/docs/

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever
Copy link
Member

@0xThiebaut We do not have this service

vyos@r4# sudo systemctl status suricata
Unit suricata.service could not be found.
[edit]
vyos@r4# 

Are there any related PRs?

@0xThiebaut
Copy link
Contributor Author

On its way :) vyos/vyos-1x#3399

@sever-sever sever-sever requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team May 2, 2024 12:01
@c-po c-po merged commit fabf532 into vyos:current May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants