build: T3664: clone vyos-1x under build dir instead of as submodule #585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This drops the use of a git submodule to manage the import of the vyos-1x python module for
scripts/image-build/build-vyos-image
, instead cloning by branch name under the build directory. Note that the argument togit.checkout
can take a tag or commit hash in place of the branch name.In addition, some minor reorganization allows (1) restoring the vyos-build git repo check to be returned to its original place before the changes to accommodate submodules (2) running basic checks earlier in the script in order to fail faster (3) earlier loading of
defaults.toml
for branch name, and later addition of vyos-1x tag/commit hash, if needed.This replaces the obsoleted #583 which will be closed.
Types of changes
Drop use of submodule in favor of clone of vyos-1x.
Related Task(s)
Component(s) name
Proposed changes
How to test
Checklist: