Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T3664: modify the module-level template path instead of setting an environment variable (backport #596) #597

Merged
merged 1 commit into from
May 7, 2024
Merged

build: T3664: modify the module-level template path instead of setting an environment variable (backport #596) #597

merged 1 commit into from
May 7, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 7, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): internal change.

Related Task(s)

Companion PR: vyos/vyos-1x#3415

Component(s) name

Build scripts.

How to test

# No env var needed anymore!
./build-vyos-image <flavor>

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #596 done by [Mergify](https://mergify.com).

@dmbaturin @mergify
build: T3664: modify the module-level template path
3c3b74c 
instead of setting an environment variable

(cherry picked from commit 58fbf3a)
@mergify mergify bot mentioned this pull request May 7, 2024
Merged
11 tasks
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label May 7, 2024
@sever-sever sever-sever merged commit 17e09a5 into sagitta May 7, 2024
3 of 4 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-596 branch May 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

Assignees
No one assigned
Labels
sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmbaturin @sever-sever