Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T3664: include build flavor name in the version file (backport #605) #608

Merged
merged 1 commit into from
May 9, 2024
Merged

build: T3664: include build flavor name in the version file (backport #605) #608

merged 1 commit into from
May 9, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 9, 2024

Change Summary

Right now, version data doesn't include flavor. If we include it, we can add a warning to add system image when the user tries to upgrade to a non-matching flavor, and also improve the update checker to suggest the correct flavor link.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Build scripts.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #605 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request May 9, 2024
Merged
11 tasks
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label May 9, 2024
@c-po c-po requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team May 9, 2024 14:21
@dmbaturin dmbaturin merged commit b4d8c01 into sagitta May 9, 2024
3 of 4 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-605 branch May 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmbaturin @c-po