Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T6446: include support URL in the version data file #649

Merged
merged 1 commit into from
Jun 5, 2024
Merged

build: T6446: include support URL in the version data file #649

merged 1 commit into from
Jun 5, 2024

Conversation

dmbaturin
Copy link
Member

Change Summary

Support URL is already present in defaults.toml but not included in version.json, this PR fixes that omission.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Build scripts.

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@dmbaturin dmbaturin requested a review from a team as a code owner June 5, 2024 15:03
@dmbaturin dmbaturin requested review from sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team June 5, 2024 15:03
@dmbaturin dmbaturin mentioned this pull request Jun 5, 2024
Merged
12 tasks
@c-po
Copy link
Member

c-po commented Jun 5, 2024

@Mergifyio backport sagitta

@c-po c-po merged commit 9c2ec5e into vyos:current Jun 5, 2024
8 checks passed
@mergify Mergify
Copy link

mergify bot commented Jun 5, 2024 •
edited
Loading

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jun 5, 2024
Merged
11 tasks
c-po added a commit that referenced this pull request Jun 5, 2024
@c-po
Merge pull request #650 from vyos/mergify/bp/sagitta/pr-649
258b865 
build: T6446: include support URL in the version data file (backport #649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

Assignees

@dmbaturin dmbaturin

Labels
backport current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmbaturin @c-po @sever-sever