Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: arm: T6474: Initial support for dynamic arch toml loading #653

Merged
merged 2 commits into from
Jun 15, 2024
Merged

docker: arm: T6474: Initial support for dynamic arch toml loading #653

merged 2 commits into from
Jun 15, 2024

Conversation

leleobhz
Copy link
Contributor

Change Summary

This PR improves Docker image building system to allow dynamic arch toml loading.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6474

Component(s) name

  • arm
  • docker

Proposed changes

This changes uses dpkg --print-architecture to move the proper toml file to /tmp folder.

How to test

Follow the Docker build guidelines.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@leleobhz
docker: arm: T6474: Initial support for dynamic arch toml loading.
946a608 
Signed-off-by: Leonardo Amaral <contato@leonardoamaral.com.br>
@leleobhz
docker: arm: T6474: Added Salt Project repo for armhf
c0af57d 
Signed-off-by: Leonardo Amaral <contato@leonardoamaral.com.br>
@leleobhz leleobhz requested a review from a team as a code owner June 11, 2024 21:19
@leleobhz leleobhz requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team June 11, 2024 21:19
dmbaturin
dmbaturin approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely dehardcode the architecture here... the change looks good at a glance.

@c-po c-po merged commit 2b3d116 into vyos:current Jun 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@leleobhz leleobhz

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leleobhz @dmbaturin @c-po