-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux-kernel: T6485: build modules for thunderbolt and thunderbolt-net #657
Conversation
d36c0f0
to
1491204
Compare
1491204
to
297c1e9
Compare
297c1e9
to
716e4e9
Compare
We should pause this PR until the CLI change or design is ready. Interface should be called ethXXX as thunderboldYYY is not supported by VyOS |
Since I’m doing this in my free time I can’t give an estimate of when this will be done, but I’m fine with pausing until I get that part done. Although I think just adding the kernel module wouldn’t have any major downside apart from a few KB bigger images.
I tried that manually and the whole eth renamer part got in the way, I still need to understand better how VyOS is doing that. Since the configuration will already have to be different than ethernet because of requiring a PCIe address, I was actually thinking of implementing as a new type of interface and follow the linux standard of calling it Currently it doesn’t show up in the interfaces list(only on ifconfig), but I can configure it normally using the |
Could also call it |
It's not about shortening the interface name. It's about how we allow ethernet interface on the CLI, see https://github.com/vyos/vyos-1x/blob/current/interface-definitions/interfaces_ethernet.xml.in#L8-L17 Can you also list some hardware reference adapters you're testing with so it's known which ones got tested by you in case someone want's to also use it. |
716e4e9
to
5355bef
Compare
👍 |
3f84d4d
to
afcb77c
Compare
afcb77c
to
23e396f
Compare
23e396f
to
2397042
Compare
Change Summary
This is the first step in order to have Thunderbolt Networking support in VyOS.
I have been successfully using a custom built kernel for this for a few months now, and with this change it will still require manual setup of the PCIe address within
systemd
andudev
rules that I plan on implementing as a proper interface in the CLI next.Types of changes
Related Task(s)
https://vyos.dev/T6485
Component(s) name
linux-kernel
Proposed changes
Add modules for
thunderbolt
andthunderbolt-net
How to test
If anyone would like to actually enable this to test, at the moment you would create the interface file
/etc/systemd/network/00-=thhunderbolt0.link
as follows:Replacing the Path with the PCIe address of the Thunderbolt controller port.
If you wan to have the interface come up when a cable is connected, you would also need to add this udev rule
/etc/udev/rules.d/60-thunderbolt-network-interfaces.rules
as follows:Checklist: