Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddclient: T5792: Use Debian build from Trixie (backport #723) #727

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 1, 2024

As part of "T5792: Upgrade to ddclient 3.11.2" in commit 368b89e, ddclient was built using build system from Debian Salsa and source code from upstream GitHub.

This was subsequently modified in commit 7f7030d to use both build system and source code from Debian Salsa.

Now that Debian has finally released ddclient 3.11.2 for Trixie, we can use the Trixie build directly instead of the custom build.

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T5792

Component(s) name

service dns dynamic

Proposed changes

How to test

smoketest

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #723 done by [Mergify](https://mergify.com).

As part of "T5792: Upgrade to ddclient 3.11.2" in commit 368b89e,
ddclient was built using build system from Debian Salsa and source code
from upstream GitHub.

This was subsequently modified in commit 7f7030d to use both build
system and source code from Debian Salsa.

Now that Debian finally has ddclient 3.11.2 release, we can use the
release tag to build the package.

(cherry picked from commit df970a1)
@mergify mergify bot requested a review from a team as a code owner August 1, 2024 11:12
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and fett0 and removed request for a team August 1, 2024 11:12
@mergify mergify bot mentioned this pull request Aug 1, 2024
11 tasks
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

👍
No issues in PR Title / Commit Title

@sever-sever
Copy link
Member

Do not merge as in the current smoketest fails

DEBUG - test_08_dyndns_vrf (main.TestServiceDDNS.test_08_dyndns_vrf) ... FAIL
DEBUG - test_08_dyndns_vrf (main.TestServiceDDNS.test_08_dyndns_vrf) ... FAIL
DEBUG - FAIL: test_08_dyndns_vrf (main.TestServiceDDNS.test_08_dyndns_vrf)
DEBUG - FAIL: test_08_dyndns_vrf (main.TestServiceDDNS.test_08_dyndns_vrf)
DEBUG - FAILED (failures=2)
ERROR - Smoketest failed :/
ERROR - Unknown error occured while VyOS!
ERROR - Hmm... system got an exception while processing.
ERROR - The ISO image is not considered usable!
DEBUG - AssertionError: 'ddclient' not found in ''
DEBUG -
DEBUG - ======================================================================
DEBUG - FAIL: test_08_dyndns_vrf (main.TestServiceDDNS.test_08_dyndns_vrf)
DEBUG - ----------------------------------------------------------------------
DEBUG - Traceback (most recent call last):
DEBUG - File "/usr/libexec/vyos/tests/smoke/cli/test_service_dns_dynamic.py", line 49, in tearDown
DEBUG - self.assertTrue(process_running(DDCLIENT_PID))
DEBUG - AssertionError: False is not true
DEBUG -
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 8 tests in 63.467s
DEBUG -
DEBUG - FAILED (failures=2)
DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_service_dns_forwarding.py
DEBUG - test_basic_forwarding (main.TestServicePowerDNS.test_basic_forwarding) ... ok

@sever-sever sever-sever merged commit e0e219d into sagitta Aug 7, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-723 branch August 7, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

4 participants