-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6674: Add build-scrips for packages without Jenkins #745
Conversation
👍 |
There are 26 instances of
With 8 different versions
I wonder why there can not be one single build.py script that's referenced (e.g. symlink) by all the packages to have a single source. Some package also have In an ideal world there would be one single |
It will take +1 month (or several weeks) to rewrite and test all packages again. Also the path for Some packages like If The frr and linux kernel uses package.toml with list of packages https://github.com/vyos/vyos-build/pull/745/files#diff-6a29cb4e9e70a3de99e08b7adddf1d106cf5af2e8f85881fd0a974cd6b8a3e52R1 The good idea if someone with good python3 and build-src skills will provide example of "good" build.py that we can use for all other packages. I do not see the same and only build.py for all packages, or just do not have enough skills to do it. Can we merge it as it is and then we can spend several month to get the |
@@ -0,0 +1,98 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's possible to call the script from a reusable location? I really would like to avoid duplicating it, if that's at all possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try it and then see what it will be.
At least some of them could be reusable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmbaturin @c-po PR ready for review
Most of the packages a built by symlinked to general build.py
Only these packages use their own build.py
linux-kernel
netfilter
ed74c8e
to
bb4c831
Compare
Add build scripts for .deb packages without Jenkins. To exclude Jenkins we need some place where we can put new builds-scripts to run in parallel (old/new) during meantime We will deprecate old Jenkins package builds in the future.
Change Summary
Add build scripts for .deb packages without Jenkins. To exclude Jenkins we need some place where we can put new builds-scripts to run in parallel (old/new) during meantime.
We will deprecate old Jenkins package builds in the future.
Types of changes
Related Task(s)
Component(s) name
package-build
Proposed changes
How to test
Checklist: