-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6703: add support for amd pstate driver #755
Conversation
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is certainly a prerequisite for anything else we do to improve AMD support, but I wonder — we can't really expect most people to edit GRUB configs by hand, neither we should. Should there be a CLI for it, or an installer tweak to add those arguments if the machine uses an AMD CPU? Should we have a generic framework for such tweaks in the installer?
Also, what happens if one tries to load that driver on non-AMD machines?
@dmbaturin I added short explanation in the phabricator task. This just compiles the pstate driver into the kernel. But it won't be active unless you suppress the acpi one and load the AMD one. I think it just won't have any effect on non-AMD cpus, the system will work with the ACPI one suppressed just without any frequency scaling. The necessary kernel arguments I plan to generate from a config command like vyos already has:
This would also allow to validate that the system is using an AMD CPU before applying it. |
Since it is completely option, it would be great to have that in Sagitta as well. |
@Mergifyio backport circinus |
✅ Backports have been created
|
Change Summary
Building amd pstate driver in the kernel. By default the acpi_cpufreq will still take precedence over the amd_pstate driver.
Kernel command line arguments are required to activate the driver.
Types of changes
Related Task(s)
https://vyos.dev/T6703
Component(s) name
kernel
Proposed changes
How to test
Set kernel arguments
initcall_blacklist=acpi_cpufreq_init amd_pstate=passive
on an AMD machine.Then after boot verify the pstate driver is active:
cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver
should beamd-pstate
Checklist: