T6684: new Debian package repo snapshot logic #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollyGurza
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
c-po and
fett0
|
👍 |
dmbaturin
requested changes
Sep 12, 2024
docker/Dockerfile
Outdated
| RUN apt-get update && apt-get install -y \ | ||
| cpio | ||
|
|
||
| RUN wget https://github.com/vyos/vyos-live-build/commit/3ddf0e979c352f2917be6a949fb8dd37b5c9f2b7.patch \ |
There was a problem hiding this comment.
Until we decide whether we really need a full-blown fork of live-build, maybe just put the patch in this repository?
Now it's a bit of a "worst of both worlds" situation: it requires a full fork but is also pulling the upstream repo. If we are ready to pull the upstream repo, the fork is not useful.
There was a problem hiding this comment.
fixed, now the patch file is stored in the docker context dir
10 tasks
patch live-build to save information about all installed packages and their source repo, including temporary packages
dmbaturin
approved these changes
Sep 16, 2024
jestabro
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch live-build to save information about all installed packages and their source repo, including temporary packages
Change Summary
Types of changes
Related Task(s)
Component(s) name
Related PR(s)
vyos/vyos-live-build#2
Proposed changes
How to test
Checklist: