Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T6653: fix a manifest generation error when using --reuse-iso #766

Merged
merged 1 commit into from
Sep 18, 2024
Merged

build: T6653: fix a manifest generation error when using --reuse-iso #766

merged 1 commit into from
Sep 18, 2024

Conversation

dmbaturin
Copy link
Member

Change Summary

Move manifest initialization before building the ISO so that the manifest file is generated correctly when a build is done with --reuse-iso to save build time.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Component(s) name

Build scripts.

Proposed changes

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@dmbaturin dmbaturin requested a review from a team as a code owner September 17, 2024 21:25
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin merged commit ead4cc2 into vyos:current Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@jestabro jestabro jestabro approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@c-po c-po Awaiting requested review from c-po c-po is a code owner automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner automatically assigned from vyos/reviewers

Assignees

@dmbaturin dmbaturin

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmbaturin @jestabro @sever-sever