Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethtool: T6729: upgrade to 6.10 to make use of more --json options (backport #769) #771

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 21, 2024

Change Summary

Same as T6078 but we now wan't to make use of ethtool --json eth0 to drop out own text based parsing of ethtool options in [1]. This is the base for moving to a better, machine readable interface

1: https://github.com/vyos/vyos-1x/blob/e47d4fd385631236da68/python/vyos/ethtool.py#L77-L105

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Package upgrade

Related Task(s)

Component(s) name

ethtool

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #769 done by [Mergify](https://mergify.com).

Same as T6078 but we now wan't to make use of ethtool --json eth0 to drop out
own text based parsing of ethtool options in [1]. This is the base for moving
to a better, machine readable interface

1: https://github.com/vyos/vyos-1x/blob/e47d4fd385631236da68/python/vyos/ethtool.py#L77-L105
(cherry picked from commit 9e7dd13)
Copy link

👍
No issues in PR Title / Commit Title

@c-po c-po enabled auto-merge September 21, 2024 19:11
@c-po c-po merged commit 4ca1736 into circinus Sep 21, 2024
7 checks passed
@sever-sever sever-sever deleted the mergify/bp/circinus/pr-769 branch October 17, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants