Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T861: Fix mellanox build by actions #778

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

sever-sever
Copy link
Member

Change Summary

Fix mellanox build by actions
Add sudo as element of the list

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Before the fix:

   File "/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/linux-kernel/./build.py", line 240, in <module>
    build_package(package, dependencies)
  File "/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/linux-kernel/./build.py", line 102, in build_package
    build_mellanox_ofed()
  File "/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/linux-kernel/./build.py", line 190, in build_mellanox_ofed
    run(['sudo ./build-mellanox-ofed.sh'], check=True)
  File "/usr/lib/python3.11/subprocess.py", line 548, in run
Cleaned up build dependency packages
Copied generated .deb packages
    with Popen(*popenargs, **kwargs) as process:
Cleaned up build dependency packages
Copied generated .deb packages
Cleaned up build dependency packages
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/subprocess.py", line 1024, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.11/subprocess.py", line 1901, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'sudo ./build-mellanox-ofed.sh'

After the fix:

./build.py --packages mlnx

$ ls -la | grep .deb
-rw-r--r--  1 root     root     2292880 Oct  1 15:51 mlnx-ofed-kernel-modules_24.07.OFED.24.07.0.6.1.1-1.kver.6.6.52-vyos_amd64.deb
-rw-r--r--  1 root     root       27996 Oct  1 15:50 mlnx-ofed-kernel-utils_24.07.OFED.24.07.0.6.1.1-1.kver.6.6.52-vyos_amd64.deb
-rw-r--r--  1 root     root       69692 Oct  1 15:50 mlnx-tools_24.07.0-1.2407061_amd64.deb

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Oct 1, 2024

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever merged commit 356ef07 into vyos:current Oct 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants