fix: error message for kwargs at call site (#2798)

Throw an ArgumentException error during validation of kwargs other than
gas, value and skip_contract_check.

tests/parser/features/external_contracts/test_external_contract_calls.py

@@ -1495,6 +1495,14 @@ def bar() -> bool: view
 def foo(a: address):
     Bar(a).bar(1)
     """,
+    """
+interface Bar:
+    def bar(x: uint256, y: uint256) -> uint256: view
+
+@external
+def foo(a: address, x: uint256, y: uint256):
+    Bar(a).bar(x, y=y)
+    """,
 ]
 
 

tests/parser/features/test_internal_call.py

@@ -449,6 +449,15 @@ def bar(a: int128) -> int128:
 def foo() -> int128:
     return self.bar(1, 2)
     """,
+    """
+@internal
+def _foo(x: uint256, y: uint256 = 1):
+    pass
+
+@external
+def foo(x: uint256, y: uint256):
+    self._foo(x, y=y)
+    """,
 ]
 
 

vyper/semantics/types/function.py

@@ -1,3 +1,4 @@
+import re
 import warnings
 from collections import OrderedDict
 from typing import Any, Dict, List, Optional, Tuple
@@ -469,7 +470,25 @@ def fetch_call_return(self, node: vy_ast.Call) -> Optional[BaseTypeDefinition]:
                 if not isinstance(kwarg.value, vy_ast.NameConstant):
                     raise InvalidType("skip_contract_check must be literal bool", kwarg.value)
             else:
-                validate_expected_type(kwarg.arg, kwarg.value)
+                # Generate the modified source code string with the kwarg removed
+                # as a suggestion to the user.
+                kwarg_pattern = fr"{kwarg.arg}\s*=\s*{re.escape(kwarg.value.node_source_code)}"
+                modified_line = re.sub(
+                    kwarg_pattern, kwarg.value.node_source_code, node.node_source_code
+                )
+                error_suggestion = (
+                    f"\n(hint: Try removing the kwarg: `{modified_line}`)"
+                    if modified_line != node.node_source_code
+                    else ""
+                )
+
+                raise ArgumentException(
+                    (
+                        "Usage of kwarg in Vyper is restricted to gas=, "
+                        f"value= and skip_contract_check=. {error_suggestion}"
+                    ),
+                    kwarg,
+                )
 
         return self.return_type