-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[codegen]: panic on potential eval order issue for some builtins #4157
fix[codegen]: panic on potential eval order issue for some builtins #4157
Conversation
--------- Co-authored-by: trocher <trooocher@proton.me>
--------- Co-authored-by: cyberthirst <cyberthirst.eth@gmail.com>
--------- Co-authored-by: trocher <trooocher@proton.me>
they are currently blocked with compiler panic; codegen fix should come later
should we add a hint on how to avoid this issue? or link to the issue tracker? |
self.var.pop() | ||
return 3 | ||
|
||
s:bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray variable
self.var.pop() | ||
return 3 | ||
|
||
s:bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray variable
self.var.pop() | ||
return 32 | ||
|
||
s:bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray variable
self.var.pop() | ||
return 3 | ||
|
||
s:bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray variable
no, i think it's pretty unlikely anybody actually runs into this. if they do, they should be encouraged to create an issue (as prompted) so we can get some real world usage data |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4157 +/- ##
==========================================
- Coverage 91.32% 90.08% -1.24%
==========================================
Files 109 109
Lines 15569 15573 +4
Branches 3418 3420 +2
==========================================
- Hits 14218 14029 -189
- Misses 923 1070 +147
- Partials 428 474 +46 ☔ View full report in Codecov by Sentry. |
What I did
alternative to #4156; panic instead of changing codegen
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture