-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[test]: add hevm harness for venom passes #4460
feat[test]: add hevm harness for venom passes #4460
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4460 +/- ##
==========================================
- Coverage 92.11% 92.09% -0.02%
==========================================
Files 119 119
Lines 16933 16936 +3
Branches 2865 2866 +1
==========================================
+ Hits 15597 15598 +1
- Misses 917 919 +2
Partials 419 419 ☔ View full report in Codecov by Sentry. |
ab27245
to
1e02f4c
Compare
self.updater._update(inst, "eq", [operands[1], IRLiteral(never)]) | ||
# canary: | ||
# self.updater._update(inst, "eq", [operands[1], IRLiteral(lo)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to leave this here or could be revert this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave it for people to review then remove
tests/hevm.py
Outdated
ctx = parse_from_basic_block(venom_source_code) | ||
|
||
num_calldataloads = 0 | ||
num_return_values = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could remove this one right (num_return_values
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, looks like it
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture