-
-
Notifications
You must be signed in to change notification settings - Fork 866
feat[venom]: inter-basic block load elimination #4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[venom]: inter-basic block load elimination #4512
Conversation
def _process_bb(self, bb, eff, load_opcode, store_opcode): | ||
# not really a lattice even though it is not really inter-basic block; | ||
# we may generalize in the future | ||
self._lattice = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary for this to be field? Could it be just local?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could just be local, but it needs to be passed to callees _handle_load and _handle_store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just tried it locally, and imo it makes the code harder to follow because you have to trace how it's being passed to the callees
elif inst.opcode == load_opcode: | ||
self._handle_load(inst) | ||
|
||
for k, v in self._lattice.items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is necessary for possible phi
insertion right? or is there any other reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, just for phi instructions, because phi instructions can only accept variables (which are defined in the predecessor block)
feat[venom]: load elimination analysis
…n-merge merge fixes and removed the unused method
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4512 +/- ##
==========================================
- Coverage 93.21% 93.21% -0.01%
==========================================
Files 136 136
Lines 19203 19299 +96
Branches 3295 3316 +21
==========================================
+ Hits 17901 17989 +88
- Misses 884 888 +4
- Partials 418 422 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture