feat[venom]: inter-basic block load elimination #4512
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def _process_bb(self, bb, eff, load_opcode, store_opcode): | ||
| # not really a lattice even though it is not really inter-basic block; | ||
| # we may generalize in the future | ||
| self._lattice = {} |
There was a problem hiding this comment.
Is it necessary for this to be field? Could it be just local?
There was a problem hiding this comment.
could just be local, but it needs to be passed to callees _handle_load and _handle_store
There was a problem hiding this comment.
i just tried it locally, and imo it makes the code harder to follow because you have to trace how it's being passed to the callees
| elif inst.opcode == load_opcode: | ||
| self._handle_load(inst) | ||
|
|
||
| for k, v in self._lattice.items(): |
There was a problem hiding this comment.
this is necessary for possible phi insertion right? or is there any other reason?
There was a problem hiding this comment.
yes, just for phi instructions, because phi instructions can only accept variables (which are defined in the predecessor block)
feat[venom]: load elimination analysis
…n-merge merge fixes and removed the unused method
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4512 +/- ##
==========================================
- Coverage 93.21% 93.21% -0.01%
==========================================
Files 136 136
Lines 19203 19299 +96
Branches 3295 3316 +21
==========================================
+ Hits 17901 17989 +88
- Misses 884 888 +4
- Partials 418 422 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture