-
-
Notifications
You must be signed in to change notification settings - Fork 849
feat[test]: add constructor tests #4648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4648 +/- ##
=======================================
Coverage 92.53% 92.53%
=======================================
Files 129 129
Lines 18593 18593
Branches 3225 3225
=======================================
Hits 17205 17205
Misses 942 942
Partials 446 446 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -893,7 +953,10 @@ def run(x: Bytes[{buffer_size}]) -> Bytes[{buffer_size}]: | |||
|
|||
res = c.run(data) | |||
|
|||
assert res == bytes(256) | |||
expected = bytes(256) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe b"\x00" * 256
return bytecode, abi | ||
|
||
|
||
def _raw_deploy(env, code, data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could add this to test utils as it's a generally useful helper
What I did