-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code documentation #4
Conversation
I'm not sure why pypy coverage now fails, since I haven't changed any code |
Thanks, I'll take a look! Not sure about that coverage miss either. |
indeed, line 96 is black.. |
Maybe we can try asking a question on the coverage bugtracker... I'll add some cosmetic edit, and keep the failed build for the reference. |
I've reported this on the |
7.3.0 is unsupported, but I got an upgrade to 7.2.0, let's see... |
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 126 126
Branches 17 17
=====================================
Hits 126 126 Continue to review full report at Codecov.
|
to the problem was the pypy version. how strange |
friendly ping |
falcon_sqla/__init__.py
Outdated
@@ -14,6 +14,6 @@ | |||
|
|||
from .manager import Manager | |||
|
|||
__all__ = [ | |||
__all__ = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to change this? I'm also a bit of control freak myself loving to make everything immutable (what can be made immutable), however, Python doc examples do use lists.
So IMHO better to stick to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for submitting this!
I'll probably need to polish this to my liking, but we'll need to actually build the docs first anyway.
Cheers 🍻 |
Add documentation to the code
While adding the docs I've notices this strangeness in #3
I've not added this to the docs, but maybe it could be appropriate to add it?