Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code documentation #4

Merged
merged 8 commits into from
Mar 21, 2020
Merged

Add code documentation #4

merged 8 commits into from
Mar 21, 2020

Conversation

CaselIT
Copy link
Contributor

@CaselIT CaselIT commented Feb 23, 2020

Add documentation to the code

While adding the docs I've notices this strangeness in #3
I've not added this to the docs, but maybe it could be appropriate to add it?

@CaselIT
Copy link
Contributor Author

CaselIT commented Feb 23, 2020

I'm not sure why pypy coverage now fails, since I haven't changed any code

@vytas7
Copy link
Owner

vytas7 commented Feb 23, 2020

Thanks, I'll take a look!

Not sure about that coverage miss either. -96 looks very odd, or at least I don't recognize it, coverage normally either list lines, or branches with ->.

@CaselIT
Copy link
Contributor Author

CaselIT commented Feb 23, 2020

indeed, line 96 is black..

@vytas7
Copy link
Owner

vytas7 commented Feb 23, 2020

Maybe we can try asking a question on the coverage bugtracker...

I'll add some cosmetic edit, and keep the failed build for the reference.

@vytas7
Copy link
Owner

vytas7 commented Feb 23, 2020

I've reported this on the coveragepy bug tracker.
Meanwhile, I'll check if Travis supports the newest PyPy3 (7.3.0), and if that could fix the issue.

@vytas7
Copy link
Owner

vytas7 commented Feb 23, 2020

7.3.0 is unsupported, but I got an upgrade to 7.2.0, let's see...

@codecov-io
Copy link

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         126    126           
  Branches       17     17           
=====================================
  Hits          126    126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0526c7...57d1135. Read the comment docs.

@CaselIT
Copy link
Contributor Author

CaselIT commented Feb 23, 2020

to the problem was the pypy version. how strange

@CaselIT
Copy link
Contributor Author

CaselIT commented Mar 18, 2020

friendly ping

@@ -14,6 +14,6 @@

from .manager import Manager

__all__ = [
__all__ = (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to change this? I'm also a bit of control freak myself loving to make everything immutable (what can be made immutable), however, Python doc examples do use lists.

So IMHO better to stick to that.

Copy link
Owner

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for submitting this!
I'll probably need to polish this to my liking, but we'll need to actually build the docs first anyway.

@vytas7 vytas7 merged commit 9e44113 into vytas7:master Mar 21, 2020
@CaselIT
Copy link
Contributor Author

CaselIT commented Mar 21, 2020

Cheers 🍻

@CaselIT CaselIT deleted the add_docs branch March 21, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants