Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add call syntax and emit constrained prefix #3

Conversation

dsyme
Copy link

@dsyme dsyme commented Jun 24, 2022

No description provided.

@dsyme
Copy link
Author

dsyme commented Jun 24, 2022

  • Fixes syntax for f<^T> so no space required
  • Fixes syntax for TypeProvider<@"abc"> so no space required
  • Add 'T.Foo
  • Add ^T.Foo
  • Emit constraint call

However there is some kind of bug in codegen that causes failure at runtime and the test I've added fails with

System.MissingMethodException: Method not found: '?'.
   at <StartupCode$FSI_0001>.$FSI_0001.main@()

However we can merge this I think, it's basically good and on the right track.

TODOs for testing to add to the list

  • Get the test I've added working
  • Test all of the above
  • Test op_Implicit and op_Explicit

if not memberFlags.IsInstance && memberFlags.IsOverrideOrExplicitImpl then
checkLanguageFeatureRuntimeAndRecover infoReader LanguageFeature.InterfacesWithAbstractStaticMembers bindm
checkLanguageFeatureAndRecover infoReader.g.langVersion LanguageFeature.InterfacesWithAbstractStaticMembers bindm
//if not memberFlags.IsInstance && memberFlags.IsOverrideOrExplicitImpl then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this temporary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to commit it, but I guess it's useful for me as can quick compile using command line to look at cidegen with lildasm using net4.x. Haven't found an easy way to do this on netcore

@vzarytovskii vzarytovskii merged commit d4504db into vzarytovskii:statics-in-interfaces-2 Jun 27, 2022
vzarytovskii added a commit that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants