perf: speed up vlc player termination

vzhd1701 · Jun 9, 2022 · 6454fa2 · 6454fa2
1 parent fd3668e
commit 6454fa2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/gridplayer/vlc_player/instance.py b/gridplayer/vlc_player/instance.py
@@ -111,11 +111,11 @@ def init_instance(self):
 
         self.vlc_instance = vlc.Instance(options)
 
-        self.vlc_instance.set_user_agent(VLC_USER_AGENT_NAME, VLC_USER_AGENT)
-
         if self.vlc_instance is None:
             raise RuntimeError("VLC failed to initialize")
 
+        self.vlc_instance.set_user_agent(VLC_USER_AGENT_NAME, VLC_USER_AGENT)
+
         self.init_logger()
 
     # process

diff --git a/gridplayer/vlc_player/player_base.py b/gridplayer/vlc_player/player_base.py
@@ -155,11 +155,13 @@ def cleanup(self):
         self._event_waiter.abort()
 
         if self._media_player is not None:
-            self.stop()
+            self._log.debug("Releasing player")
 
-            self._media_player.release()
+            media_player = self._media_player
             self._media_player = None
 
+            media_player.release()
+
     def error(self, message):
         self._log.error(message)
         self.notify_error()