with_shutdown for Tokio app
#113
Conversation
humphrey/src/tokio/app.rs
Outdated
| sd.cancelled().await | ||
| } else { | ||
| loop { | ||
| let _ = tokio::time::sleep(std::time::Duration::from_secs(9999)); |
There was a problem hiding this comment.
If you're trying to express "future that never resolves" you should use future::pending I think.
|
For what it's worth, I don't do much Rust async either, but I thought it would be good for people to have the option of using Humphrey with the whole Tokio ecosystem. For example, it was particularly awkward (near impossible) to use it with lots of database connection crates that rely heavily on async before I added the Tokio feature. |
Grinkers
force-pushed
the
shutdown-tokio
branch
from
34b7b5c
to
a266ff0
Compare
Ah, that makes a lot of sense. I was wondering why adding the bloat/dependencies when it goes against the default case. I pushed with |
humphrey/src/tokio/app.rs
Outdated
| .with_peer_result(stream.peer_addr()), | ||
| ); | ||
| let shutdown = async { | ||
| if let Some(sd) = self.shutdown.clone() { |
There was a problem hiding this comment.
Can we change the .clone() to .as_ref()? Just to avoid the unnecessary allocation.
|
CI ran too! Nice. |
I don't do much rust async. I find it overly annoying for little benefit. One of the reasons I found this crate was it's one of the few that don't have page long dependency trees, super simple, and low-latency.
I pulled in https://docs.rs/tokio-util/latest/tokio_util/sync/struct.CancellationToken.html
which is part of the tokio project https://github.com/tokio-rs/tokio/tree/master/tokio-util
as I think this might be exactly what we're looking for.