Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAN / devided by zero on c1a0c, c1a1a, c1a4b #461

Closed
0x4E69676874466F78 opened this issue Mar 3, 2023 · 6 comments · Fixed by #726
Closed

NAN / devided by zero on c1a0c, c1a1a, c1a4b #461

0x4E69676874466F78 opened this issue Mar 3, 2023 · 6 comments · Fixed by #726
Labels
bug Something isn't working ray tracing visual bug Visual glitches, something looks incorrectly

Comments

@0x4E69676874466F78
Copy link
Collaborator

image
image
image
image
@0x4E69676874466F78 0x4E69676874466F78 added bug Something isn't working ray tracing visual bug Visual glitches, something looks incorrectly labels Mar 3, 2023
@w23
Copy link
Owner

w23 commented Mar 4, 2023

Когда это началось примерно?

@0x4E69676874466F78
Copy link
Collaborator Author

Когда это началось примерно?

c5a1343 ещё рабочий
3ecd21a сломалось

@0x4E69676874466F78 0x4E69676874466F78 moved this to 🆕 New in HLRT Mar 4, 2023
@0x4E69676874466F78
Copy link
Collaborator Author 

#ifndef RAY_BOUNCE
#define PROJECTED
//#define SOLID
//#define SIMPLE_SOLID
#else
//#define PROJECTED
//#define SOLID
//#define SIMPLE_SOLID
#endif

в else нефига, значит getPolygonLightSampleSimple и видимо он и багованный. Сделал для теста #define SIMPLE_SOLID и всё норм.

@0x4E69676874466F78
Copy link
Collaborator Author

0x4E69676874466F78 commented Mar 18, 2023 •
edited
Loading

Ещё есть желтизна на c4a1a, прыгаем на второй остров и там:

Image

Сразу заметишь разницу.

И на c4a1f там прям чернота и зеленью:

Image

@0x4E69676874466F78 0x4E69676874466F78 changed the title NAN / devided by zero on c1a0c, c1a1a NAN / devided by zero on c1a0c, c1a1a, c1a4b Sep 1, 2023
@0x4E69676874466F78
Copy link
Collaborator Author

На c1a4b тоже желтизна.

@0x4E69676874466F78
Copy link
Collaborator Author

На c1a2 это выглядит более локально, без резкого переключения на весь экран:
image

@w23 w23 moved this from 🆕 New to 🏗 In progress in HLRT Jan 11, 2024
w23 added a commit that referenced this issue Jan 11, 2024
@w23
vk: rt: skip loading zero-area polygon lights
8f5b565 
These cause NaNs in lighting computation, which leads to visual glitches, like strong yellow or green lighting.

Fixes #461
@w23 w23 mentioned this issue Jan 11, 2024
Merged
24 tasks
@w23 w23 moved this from 🏗 In progress to 👀 In review in HLRT Jan 12, 2024
@w23 w23 closed this as completed in #726 Feb 1, 2024
w23 added a commit that referenced this issue Feb 1, 2024
@w23
Merge pull request #726 from w23/handmade-brdfs
67ea7af 
Hand-made organic bespoke GMO-free BRDFs

- [x] Fix black metals in #666
  - [x] Better diffuse-vs-specular channels tracking
  - [x] specular reflections
- [x] Fix new `test_material` glitches
- [x] Fix #461 
- [x] Fix #151 
- [x] Fix #266 
- [x] Filter out zero-area degenerate triangles (NOTE: might affect normal smoothing)
- [x] Implement #126 
  - [x] sun solid angle parametrization
- [x] Make new brdfs sampling functions
- [ ] distant light circular glitches
  - [x] not enough float precision, addressed to a degree with slight modifications to equations
- [x] Address glow over weapons in RT, see #442 
- [x] bounces
  - [x] diffuse
    - [x] why is it so dark?
  - [x] specular
- [x] Peformance differences. Why is there no CPU-GPU parallelism anymore?
  - [x] `VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT` forces cpu-gpu sync. 💩 
    - [x] Make a special flag for it
- [x] Update rendertests
  - [x] add more channels
  - [x] add white furnace display test
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in HLRT Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ray tracing visual bug Visual glitches, something looks incorrectly
Projects
HLRT
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hand-made organic bespoke GMO-free BRDFs w23/xash3d-fwgs
2 participants
@w23 @0x4E69676874466F78