Experimental emissive water #754
Merged
+134
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does fix a bunch of emissive water surfaces missing, but not all. It also entangles the code even more. Not sure if its worth it, maybe a better approach is possible.
Brush model water surfaces might be emissive for e.g. toxicgrn textures. For now we're making original, not tesselated, surfaces emissive for performance reasons. However, tesselated surfaces are not coplanar with emissive ones, and therefore cast weird shadows. Add material flag to make sure that given model doesn't cast shadows (might be useful not only for water, but e.g. windows and other things). Add geometry bit for opaque models casting shadows. I.e. not all opaque models cast shadows now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.