Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaked view #1

Merged
merged 2 commits into from
Oct 27, 2014
Merged

Tweaked view #1

merged 2 commits into from
Oct 27, 2014

Conversation

rashidkpc
Copy link

I changed the advance toggle and tweaked some padding to make chosen look more like the other inputs. I also wrapped some stuff in form-groups.

@rashidkpc
Copy link
Author

Also added script inputs to the other aggs that support it, although for whatever reason don't document it.

@w33ble w33ble merged this pull request into w33ble:advanced-aggs Oct 27, 2014
w33ble pushed a commit that referenced this pull request Nov 22, 2014
@lukasolson
Merge pull request #1 from rashidkpc/pr/1999
4d52fb5 
Tweak CSS, change em to mark
w33ble pushed a commit that referenced this pull request Dec 5, 2014
@rashidkpc
Merge pull request #1 from w33ble/feature/doc_viewer
18a3d02 
fix dov viewer tab style
w33ble pushed a commit that referenced this pull request Dec 30, 2014
@grouma
Merge pull request #1 from spenceralger/segment_in_courier
90aed85 
Segmented fetch in courier
w33ble pushed a commit that referenced this pull request Jan 21, 2015
@simianhacker
Merge pull request #1 from spenceralger/removeDevServer
9820571 
removed the dev server and cleaned up package.json
w33ble pushed a commit that referenced this pull request Aug 12, 2015
Merge pull request #1 from spalger/pr/4434
164e55b 
convert format changing to match date_range
w33ble pushed a commit that referenced this pull request Sep 14, 2015
@epixa
Merge pull request #1 from w33ble/fix/advanced-listener
075a18e 
unhook the change:config listener on destroy
w33ble pushed a commit that referenced this pull request Oct 19, 2015
Merge pull request #1 from rashidkpc/enhancement/sidebar-hover
3223a4b 
Add hover to match spy tab, make bar smaller
w33ble pushed a commit that referenced this pull request Oct 30, 2015
Merge pull request #1 from w33ble/testSettings
53a2f6d 
show absolute path for screenshot
w33ble pushed a commit that referenced this pull request Mar 2, 2016
Merge pull request #1 from w33ble/fix/timeouts
456a5dc 
Fix/timeouts
w33ble pushed a commit that referenced this pull request Mar 29, 2016
@colings86
Merge pull request #1 from spalger/pr/6643
184c0a3 
[discover/tests] update rigid test data
w33ble pushed a commit that referenced this pull request Apr 4, 2016
@panda01
Merge pull request #1 from rashidkpc/pr/6645
6b47ced 
Move kbn-loading-indicator to element
w33ble pushed a commit that referenced this pull request Sep 7, 2016
Enable auto refresh functionality, closes #1
6b3b9a4
w33ble pushed a commit that referenced this pull request Jun 9, 2017
@nreese
Timepicker on the right (elastic#11980)
5c075f2 
* quick panel moved to directive

* move relative to directive

* move absolute to directive

* move stuff from timepicker directive to new directives

* move timepicker to right with flexbox

* remove left padding for kbn-timepicker-section

* merge in timepicker.html changes from - Improve accessibility of the Datepicker. (elastic#11753)

* Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds (#1)

* Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds, so the content doesn't jump around as you switch modes..

* Make kbn-timepicker-content responsive so that it stacks content on narrower screens.

* Combine Relative input and select fields using kuiFieldGroup.

* Make Timepicker submit button wider.

* Align button on right.

* migrate inputs from form-control to kui classes

* update generated dist/ui_framework.css

* fix broken tests

* create kbn-timerpicker-nav-button class and update kbn-timepicker-section to make each column the same width
w33ble pushed a commit that referenced this pull request Mar 12, 2019
@flash1293 @timroes
Use embeddable registry in add panel (elastic#31400)
f935c14 
* Prepare control flow to use embeddable factories in add panel

* Rewrite saved object finder and add tests

* Fix usages of new saved object finder

* fix test failures

* fix some functional tests and re-introduce makeUrl

* fix tests

* remove direct hrefs in saved_object_lists

* PR review fixes

* update snapshot

* overwrite width of viz dialog

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* fix tests

* review fixes #1

* review fixes #2

* dont use classname in functional test

* remove call to action button prop

* align buttons correctly

* fix tests

* remove debugging statement

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* review fixes #3

* improve filter behavior and enable it for search wizard

* adjust functional tests for new filter behavior

* Change translation id due to string change

* Update Jest snapshot
w33ble pushed a commit that referenced this pull request Mar 12, 2019
@timroes
Use embeddable registry in add panel (elastic#31400) (elastic#32885)
358ab0d 
* Prepare control flow to use embeddable factories in add panel

* Rewrite saved object finder and add tests

* Fix usages of new saved object finder

* fix test failures

* fix some functional tests and re-introduce makeUrl

* fix tests

* remove direct hrefs in saved_object_lists

* PR review fixes

* update snapshot

* overwrite width of viz dialog

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* fix tests

* review fixes #1

* review fixes #2

* dont use classname in functional test

* remove call to action button prop

* align buttons correctly

* fix tests

* remove debugging statement

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* review fixes #3

* improve filter behavior and enable it for search wizard

* adjust functional tests for new filter behavior

* Change translation id due to string change

* Update Jest snapshot
w33ble pushed a commit that referenced this pull request May 20, 2019
@mshustov
[New Platform] Validate config upfront (elastic#35453)
6b5c01c 
* Introduce new convention for config definition.

We need to define a way to acquire configuration schema as a part of
plugin definition. Having schema we can split steps of
config validation and plugin instantiation.

* Discover plugins, read their schema and validate the config.

Config validation finished before core services and plugins read from it.
That allows us to fail fast and have predictable validation results.

* Instantiate plugins using DiscoveredPluginsDefinitions.

* Update tests for new API.

* test server is not created if config validation fails

* move plugin discovery to plugin service pre-setup stage.

Set validation schemes in ConfigService.preSetup stage.

* fix eslint problem

* generate docs

* address Rudolfs comments

* separate core services and plugins validation

* rename files for consistency

* address comments for root.js

* address comments #1

* useSchema everywhere for consistency. get rid of validateAll

* plugin system runs plugin config validation

* rename configDefinition

* move plugin schema registration in plugins plugins service

plugins system is not setup when kibana is run in optimizer mode,
so config keys aren't marked as applied.

* cleanup

* update docs

* address comments
w33ble pushed a commit that referenced this pull request May 21, 2019
@mshustov
[New Platform] Validate config upfront (elastic#35453) (elastic#36439)
581d499 
* Introduce new convention for config definition.

We need to define a way to acquire configuration schema as a part of
plugin definition. Having schema we can split steps of
config validation and plugin instantiation.

* Discover plugins, read their schema and validate the config.

Config validation finished before core services and plugins read from it.
That allows us to fail fast and have predictable validation results.

* Instantiate plugins using DiscoveredPluginsDefinitions.

* Update tests for new API.

* test server is not created if config validation fails

* move plugin discovery to plugin service pre-setup stage.

Set validation schemes in ConfigService.preSetup stage.

* fix eslint problem

* generate docs

* address Rudolfs comments

* separate core services and plugins validation

* rename files for consistency

* address comments for root.js

* address comments #1

* useSchema everywhere for consistency. get rid of validateAll

* plugin system runs plugin config validation

* rename configDefinition

* move plugin schema registration in plugins plugins service

plugins system is not setup when kibana is run in optimizer mode,
so config keys aren't marked as applied.

* cleanup

* update docs

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rashidkpc @w33ble