Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand implementations list #7

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open

Expand implementations list #7

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
099ed0f
Link to Spruce implementation
clehner Nov 18, 2021
ee30f93
Link to Spruce/ssi implementation on docs.rs
clehner Nov 18, 2021
df61eab
Add Danube Tech implementation link
clehner Nov 19, 2021
bc37222
Use ssi repo link for Spruce implementation
clehner Nov 19, 2021
638538a
List implementation languages
clehner Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@
## Implementations

- [dif](https://github.com/decentralized-identity/lds-ecdsa-secp256k1-2019.js)
- [digitalbazaar](https://github.com/digitalbazaar/secp256k1-key-pair)
- [digitalbazaar](https://github.com/digitalbazaar/secp256k1-key-pair)
- [spruce](https://docs.rs/ssi/0.2.0/ssi/ldp/struct.EcdsaSecp256k1Signature2019.html)
peacekeeper marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon my unfamiliarity with docs.rs and rust, but is that the best link for an implementation? Looks like just API docs to me. Maybe also link to https://github.com/spruceid/ssi or wherever the code lives?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure... Originally I was going to use this link: https://github.com/spruceid/ssi/blob/15e944620e20b31b4644edad094e01ff7b418e44/src/ldp.rs#L822 but then thought it might be nicer to use the docs page. In a future version these docs should have more human-readable content. The docs.rs pages have links to the source/repository in the navigation. But maybe it would be better to just to link to the repo, as that is more intended to be an entry point...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, that repo link was not obvious to me. I used a search engine. It also seems a specific 0.2.0 link would get stale easily as the lib matures. And this is getting off topic, but implementation links should probably list the implementation language(s).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point about the version. A wildcard could be used in the docs.rs URL to refer to the latest version, but the latest release of this crate doesn't have the docs building currently. Updated to use the repo link: bc37222.

About listing the implementation languages, sure why not: 638538a

- [danubetech](https://github.com/weboftrustinfo/ld-signatures-java)