Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error for embedded quotes around MH #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bshambaugh
Copy link

@bshambaugh bshambaugh commented Aug 9, 2019

Create some syntax changes :

<section anchor="mh-digest-algorithm" title="The "MH" Digest Algorithm">

to

<section anchor="mh-digest-algorithm" title="The &quot; MH&quot;  Digest Algorithm">

@bshambaugh bshambaugh requested a review from msporny as a code owner August 9, 2019 23:46
@@ -2,9 +2,9 @@
<!DOCTYPE rfc PUBLIC "-//IETF//DTD RFC 2629//EN" "http://xml.resource.org/authoring/rfc2629.dtd" [
<!ENTITY rfc2119 SYSTEM "http://xml.resource.org/public/rfc/bibxml/reference.RFC.2119.xml">
<!ENTITY rfc6234 SYSTEM "http://xml.resource.org/public/rfc/bibxml/reference.RFC.6234.xml">
<!ENTITY rfc7693 SYSTEM "http://xml.resource.org/public/rfc/bibxml/reference.RFC.7693.xml">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ENTITY should be in numerical order, this breaks that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that is being moved back, please fix the 6234 one was already out of order.

@@ -501,7 +501,7 @@ NOTE: The most up to date place for developers to find the table above is
</t>
</section>

<section anchor="mh-digest-algorithm" title="The "MH" Digest Algorithm">
<section anchor="mh-digest-algorithm" title="The &quot;MH&quot; Digest Algorithm">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants