Sima types #904
Closed
Sima types #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2023 15:12
OR13
approved these changes
Nov 21, 2023
TallTed
reviewed
Nov 21, 2023
Comment on lines
+572
to
+573
| "expectedDateOfExport": "2022-04-02", | ||
| "expectedDateOfImport": "2022-04-09", |
There was a problem hiding this comment.
The trouble with making these date instead of date-time is that timezone falls off, which can make the date ambiguous as it changes at midnight — but which midnight?
TallTed
reviewed
Nov 21, 2023
docs/openapi/components/schemas/credentials/SIMASteelImportLicenseCredential.yml
Outdated
Show resolved
Hide resolved
…enseCredential.yml Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.