Remove query interface from spec #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprorock
approved these changes
Jan 18, 2021
kimdhamilton
approved these changes
Jan 22, 2021
TallTed
reviewed
Jan 27, 2021
Comment on lines
+1142
to
+1144
| In order to ensure portability, wallet interfaces MUST be functions of | ||
| JSON, and not take complex instances of classes, functions or other | ||
| types of object. |
There was a problem hiding this comment.
Suggested change
| In order to ensure portability, wallet interfaces MUST be functions of | |
| JSON, and not take complex instances of classes, functions or other | |
| types of object. | |
| In order to ensure portability, wallet interfaces MUST be functions of | |
| JSON, and not take complex instances of classes, functions, or other | |
| types of object. |
Comment on lines
+1154
to
+1155
| This method may not be necessary, for implementations that rely on | ||
| external storage, such as Encrypted Data Vaults. |
There was a problem hiding this comment.
Suggested change
| This method may not be necessary, for implementations that rely on | |
| external storage, such as Encrypted Data Vaults. | |
| This method may not be necessary for implementations that rely on | |
| external storage, such as Encrypted Data Vaults. |
Comment on lines
+1168
to
+1169
| This method may not be necessary, for implementations that rely on | ||
| external storage, such as Encrypted Data Vaults. |
There was a problem hiding this comment.
Suggested change
| This method may not be necessary, for implementations that rely on | |
| external storage, such as Encrypted Data Vaults. | |
| This method may not be necessary for implementations that rely on | |
| external storage, such as Encrypted Data Vaults. |
Comment on lines
+1181
to
+1182
| This method may not be necessary, for implementations that rely on | ||
| external storage, such as Encrypted Data Vaults. |
There was a problem hiding this comment.
Suggested change
| This method may not be necessary, for implementations that rely on | |
| external storage, such as Encrypted Data Vaults. | |
| This method may not be necessary for implementations that rely on | |
| external storage, such as Encrypted Data Vaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses concerns about HTTP / interface portability raised on #46