Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm additions #1

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Algorithm additions #1

merged 4 commits into from
Jan 8, 2024

Conversation

wes-smith
Copy link
Collaborator

added creation, verification algorithms

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid first draft. Some comments for consideration. I'll re-review when you make another pass.

@wes-smith
Copy link
Collaborator Author

@msporny All explicit changes are in. Not sure about "making these algorithms fully normative is probably the right thing to do (with pointers to other specifications w/ further normative algorithms)" - I removed the informative tag for Section 4 but am not sure if the pointers I have are adequate.

Side note - what's the easiest way for me to preview changes with the correct formatting? Using a browser to open the html isn't very useful.

@msporny
Copy link
Contributor

msporny commented Jan 8, 2024

@msporny All explicit changes are in. Not sure about "making these algorithms fully normative is probably the right thing to do (with pointers to other specifications w/ further normative algorithms)" - I removed the informative tag for Section 4 but am not sure if the pointers I have are adequate.

Ah, I meant: "Move these two subsections into the "Algorithms" section."

Side note - what's the easiest way for me to preview changes with the correct formatting? Using a browser to open the html isn't very useful.

Set up a web server on your local machine and serve the directory for the specification from that web server. You should then be able to just reload the page after you make changes. That's the setup I use and it works well for a variety of specifications. In the future, you will want to serve a "specifications" directory and then link to every specification you're currently working on from that directory.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 8, 2024

PR Preview Action v1.4.6
🚀 Deployed preview to https://digitalbazaar.github.io/verifiable-barcodes/pr-preview/pr-1/
on branch gh-pages at 2024-01-08 18:33 UTC

@wes-smith wes-smith force-pushed the wes branch 3 times, most recently from 4764952 to 04712c4 Compare January 8, 2024 18:31
wes-smith and others added 4 commits January 8, 2024 13:32
added creation, verification algorithms

Update index.html

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Algorithm additions

added creation, verification algorithms

Update index.html

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Move implementation instr. to Algorithms section

Change variable names to better reflect requirements

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Change variable names for better conformity

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Change variable names for better conformity

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Algorithm additions

added creation, verification algorithms

Update index.html

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Update index.html

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Move implementation instr. to Algorithms section

Change variable names to better reflect requirements

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Change variable names for better conformity

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
@wes-smith
Copy link
Collaborator Author

@msporny should be good to go whenever you're ready

@msporny msporny merged commit 5391d8a into main Jan 8, 2024
1 check passed
@msporny msporny deleted the wes branch January 8, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants