Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various suggested edits #3

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Various suggested edits #3

merged 1 commit into from
Apr 1, 2020

Conversation

kenrb
Copy link
Collaborator

@kenrb kenrb commented Mar 30, 2020

  • Spelling+grammar touch ups (mostly hyphenating compound adjectives, which is inconsistent throughout)
  • Replacing 'single sign-on' in the introduction. You can revert that if you disagree, but I think of SSO meaning things like Kerberos, where you get a token that allows you authenticated access to a set of resources. It is a little bit different from federated identity.
  • Cleanup to the "Identity Provisioning Flow" section which has some vestigial language from my earlier idea of having consent precede the RP's identity request being supplied to the IDP.

@kenrb
Some suggestions
fb2b953 
- Spelling+grammar touch ups (mostly hyphenating compound adjectives, which is inconsistent throughout)
- Replacing 'single sign-on' in the introduction. You can revert that if you disagree, but I think of SSO meaning things like Kerberos, where you get a token that allows you authenticated access to a set of resources. It is a little bit different from federated identity.
- Cleanup to the "Identity Provisioning Flow" section which has some vestigial language from my earlier idea of having consent precede the RP's identity request being supplied to the IDP.
@kenrb kenrb requested a review from samuelgoto March 30, 2020 21:31
@samuelgoto samuelgoto merged commit 8f58ef3 into master Apr 1, 2020
@kenrb kenrb deleted the kenrb-suggestions branch October 8, 2020 19:33
@yi-gu yi-gu mentioned this pull request Feb 9, 2023
Closed
@yi-gu yi-gu mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelgoto samuelgoto samuelgoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenrb @samuelgoto