clarify token validation is the RP's responsibility #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm unsure if it makes sense to even delve into (validation etc.) this given the FedCM API leaves it open what is passed here, or just name this as an general example. The FedCM token could as well not be an ID token type piece of information, but rather something that resembles an auth code, access token, ....
Keeping it more generic in pointing out that its the RPs role to leverage that token in general in a non FedCM related process makes sense I would think.
kdenhartog
commented
Jan 12, 2023
github-actions bot
added a commit
that referenced
this pull request
Jan 13, 2023
SHA: e346efe Reason: push, by samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #318
Preview | Diff