-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow auto-reauthentication in FedCM #458
Conversation
Do we need to update the algorithm to take mediation requirements into account? Or can it be implied? |
Pretty sure we do, the algorithm is currently normatively requiring showing a dialog e.g. in step 7 of https://fedidcg.github.io/FedCM/#create-an-identitycredential |
Hmm I thought we might get the logic for free from credential management but this appears to not be the case. We currently have all our stuff in |
Ok, I took a stab at it, please take a look? I can loop in Mozilla folks once it looks good to you. |
@bvandersloot-mozilla @cboozar @martinthomson - requesting Mozilla review! As y'all had requested, we're not filing a standards position issue. So consider this it :) Please take a look. |
I think these changes make sense, not sure why some of the variables needed shortening but readable either way |
Thanks for the review, Cameron! Merging then. Re variable shortening, perhaps you mean |
SHA: 6ca279e Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fixes #429
Preview | Diff