Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove note on IdP to validate nonce (#582) #583

Merged
merged 1 commit into from
May 15, 2024
Merged

Remove note on IdP to validate nonce (#582) #583

merged 1 commit into from
May 15, 2024

Conversation

obfuscoder
Copy link
Contributor

@obfuscoder obfuscoder commented May 15, 2024 •
edited by pr-preview bot
Loading

@cbiesinger
Copy link
Collaborator

lgtm but could you resolve the IPR issue as described in https://labs.w3.org/repo-manager/pr/id/fedidcg/FedCM/583 ?

@samuelgoto
Copy link
Collaborator

LGTM++

@npm1
Copy link
Collaborator

npm1 commented May 15, 2024

Yea ideally you can fix the affiliation. But I'm also open to consider this a non-substantive change since it just removes a note

@obfuscoder
Copy link
Contributor Author

As this PR is just about removing content, you could probably waive this requirement for this one. I'll try to get this IPR sorted out with my company, but it willl probably take a while.

@samuelgoto
Copy link
Collaborator

SGTM.

Waving as non-substantive.

@samuelgoto samuelgoto merged commit 10794f7 into w3c-fedid:main May 15, 2024
1 of 2 checks passed
github-actions bot added a commit that referenced this pull request May 15, 2024
@obfuscoder @github-actions
Remove note on IdP to validate nonce (#582) (#583)
726c945 
SHA: 10794f7
Reason: push, by samuelgoto

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to mattdanielbrown/WebID that referenced this pull request May 16, 2024
@obfuscoder @github-actions
Remove note on IdP to validate nonce (w3c-fedid#582) (w3c-fedid#583)
bef12c5 
SHA: 10794f7
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@samuelgoto samuelgoto mentioned this pull request Jun 17, 2024
Closed
npm1 pushed a commit that referenced this pull request Jul 31, 2024
@obfuscoder @npm1
Remove note on IdP to validate nonce (#582) (#583)
2d1752e 
Co-authored-by: Kai Lehmann <kai.lehmann@1und1.de>
npm1 pushed a commit that referenced this pull request Sep 18, 2024
@obfuscoder @npm1
Remove note on IdP to validate nonce (#582) (#583)
8e42829 
Co-authored-by: Kai Lehmann <kai.lehmann@1und1.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@obfuscoder @cbiesinger @samuelgoto @npm1