Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPWD preparation #634

Merged
merged 4 commits into from
Aug 16, 2024
Merged

FPWD preparation #634

merged 4 commits into from
Aug 16, 2024

Conversation

simoneonofri
Copy link
Contributor

@simoneonofri simoneonofri commented Aug 16, 2024

as w3c/transitions#647

  • update index.bs with metadata
  • update SVGs
  • update w3c.json

 - update index.bs with metadata
  - update SVGs
@npm1
Copy link
Collaborator

npm1 commented Aug 16, 2024

What are the svg updates? I don't see a noticeable difference in the images

Repository: fedidcg/FedCM
Editor: Nicolás Peña Moreno, Google Inc. https://google.com, npm@chromium.org
Former Editor: Sam Goto, Google Inc. https://google.com, goto@google.com
Status: w3c/FPWD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know FPWD is a thing? When would this change to WD?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FPWD is a First Public Working Draft :)

Former Editor: Sam Goto, Google Inc. https://google.com, goto@google.com
Status: w3c/FPWD
Group: fedid
TR: http://www.w3.org/TR/fedcm/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist currently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for an ack to create it

@simoneonofri
Copy link
Contributor Author

some attributes added by the editor and the image ids.

this happened because they are embedded in the HTML

Copy link
Collaborator

@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@samuelgoto samuelgoto merged commit beadf81 into main Aug 16, 2024
1 check passed
@samuelgoto samuelgoto deleted the fpwd branch August 16, 2024 17:06
github-actions bot added a commit that referenced this pull request Aug 16, 2024
SHA: beadf81
Reason: push, by samuelgoto

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
npm1 pushed a commit that referenced this pull request Sep 18, 2024
* FPWD preparation
 - update index.bs with metadata
  - update SVGs

* Update w3c.json

from CG to WG

* Update w3c.json

* Update w3c.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants