Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user agent to wait or reject the request before any fetch #676

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

npm1
Copy link
Collaborator

@npm1 npm1 commented Nov 1, 2024

See #675


Preview | Diff

@npm1 npm1 requested a review from samuelgoto November 1, 2024 20:41
@npm1
Copy link
Collaborator Author

npm1 commented Nov 1, 2024

isn't this redundant with https://w3c-fedid.github.io/FedCM/#create-identity-credential:~:text=The%20user%20agent%20can%20decide%20when%20to%20continue%20with%20the%20next%20steps. ?

Yea I was just updating since I saw that. Unfortunately that is not good enough since it does not allow rejecting, so moved it to right at the beginning of the create algorithm.

@npm1 npm1 changed the title Allow user agent to show a dialog before accounts fetch Allow user agent to wait or reject the request before any fetch Nov 1, 2024
Copy link
Collaborator

@cbiesinger cbiesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good.

spec/index.bs Outdated Show resolved Hide resolved
npm1 and others added 3 commits November 4, 2024 12:30
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
spec/index.bs Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants