Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite attempt to resolve #118, #119, #120: Alternate to #138 #148

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

cwilso
Copy link
Collaborator

@cwilso cwilso commented Jan 26, 2024

Fixes #118, #119, #120.


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jan 29, 2024, 6:03 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@cwilso cwilso changed the title Rewrite attempt to resolve #118, #119: Alternate to #138 Rewrite attempt to resolve #118, #119, #120: Alternate to #138 Jan 27, 2024
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good simplification.

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, still looks good, wondering if a slight change would help it read more specific to W3C. Maybe just:
s/The W3C must embed core values/The W3C must its embed core values

@cwilso cwilso merged commit ff3e260 into main Jan 30, 2024
4 checks passed
@cwilso cwilso deleted the embed-core-values branch January 30, 2024 15:49
@cwilso cwilso restored the embed-core-values branch January 30, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demonstrating core principles
3 participants