Specifying visual viewport for root intersection rect and clarifying … #128
Conversation
Fix pinch zoom reference
This should integrate better with the existing html event loop spec.
Use a document-centric processing model.
The concept of a node being "deleted", as opposed to merely being detached from the DOM, is not specified by any standard, so we shouldn't refer to it here.
Don't specify behavior of observer with invalid root.
Incorrectly used undefined `element` property (out of date?), undefined variable and syntax error (stray `{`).
Fix explainer code example
Previous code used for-in on an array, which isn't recommended. Changed to for-of.
Modernising the example
Correct unreliable checks for properties w/ more reliable ones.
As per #120
Use CSS classes on container and inner-scroll-surface. Fix invalid rootMargin.
</h3> -> </h4>
mismatched closing tag
fixing typos
Fixed Data Scrollers example
…coordinate space for rootMargin
|
LGTM |
|
When can this be merged? Anything else you need from me to help get this in? |
|
I'd prefer it if we could define the option to select layout vs. visual viewport at the same time as we change the language, and the language should probably use "visual or layout viewport" as appropriate. |
|
Can we treat that as a separate, augmenting change following this one up? I think the addition of an option probably needs more discussion (e.g. see my and David's comments on #95) and I don't think it results in any change to the default behavior, which is what this issue/PR is focused on. |
|
@ChumpChief - Apologies for letting this slide for so long, but could you join the WICG in order to appease the IPR bots? |
|
Please merge the requested change to the Our apologies for the inconvenience. |
|
@ChumpChief - friendly ping :) Can you join the WICG so the IPR bots would be happy and green? |
|
Wow, old one :) I think I've linked it now, let me know if there's still any issue. |
|
@ChumpChief Yeah, dug it from the bottom of my inbox... :D repo-manager is still not happy. Not sure why |
|
@ChumpChief could you try linking your Github account with your W3C account? Also, please remove the .html file from this pull request? the .travis bot will generate the document for you once you submit the .bs file :) (Thanks @yoavweiss ;) |
|
I linked it yesterday as noted. Shows up correctly on the connectedaccounts page as well. |
|
Thanks for the update @ChumpChief . @dontcallmedom the IRP checker reported an error when we tried to revalidate a PR after migrating the repo from WICG... any suggestion?
|
|
@siusin fixed - at the moment, the IPR checker doesn't handle correctly handling of existing Pull Requests after migration of a repo, so this has to be fixed manually. |
|
Thanks @dontcallmedom ! |
|
@yoavweiss Looking to wrap this one up -- anything you need me to do? |
…coordinate space for rootMargin
This PR corresponds to issue #95 @szager-chromium @bokand @RByers