Define content clip #386
Define content clip #386
Conversation
There was a problem hiding this comment.
I think this should probably use https://drafts.csswg.org/css-overflow/#scroll-container instead.
There are elements for which the overflow-x/y styles don't necessarily create a scroll container (e.g., an <img> element, or an element with display: none).
index.bs
Outdated
| @@ -304,6 +308,8 @@ or else the <a>top-level browsing context</a>'s <a>document</a> node | |||
| (referred to as the <dfn for="IntersectionObserver">implicit root</dfn>) if | |||
| the {{IntersectionObserver/root}} attribute is <code>null</code>. | |||
|
|
|||
| An {{Element}} is defined as having an <dfn for="IntersectionObserver">overflow clip</dfn> if its computed style has a value other than "visible" for its <a>overflow</a>, <a>overflow-x</a>, or <a>overflow-y</a> property. | |||
There was a problem hiding this comment.
"overflow clip" seems quite an odd term because clip is a valid value of the overflow property, fwiw.
There's no need to mention the overflow property explicitly, as it's just a shorthand of overflow-x and overflow-y.
There was a problem hiding this comment.
I changed this to "content clip".
index.bs
Outdated
| @@ -581,7 +587,7 @@ run these steps: | |||
| 2. Let |container| be the <a>containing block</a> of the <a>target</a>. | |||
| 3. While |container| is not the <a>intersection root</a>: | |||
| 1. Map |intersectionRect| to the coordinate space of |container|. | |||
| 2. If |container| has overflow clipping or a css <a>clip-path</a> property, | |||
| 2. If |container| has an <a>overflow clip</a> or a CSS <A>clip-path</a> property, | |||
There was a problem hiding this comment.
The casing change at the left of clip-path seems unintentional.
issue#351
szager-chromium
force-pushed
the
overflow-clip-dfn
branch
from
e6bfb3c to
b46da08
Compare
"Scroll container" is not quite right, because it is defined as an element that can be scrolled by the user, whereas IntersectionObserver should be applying the clip regardless of whether the element is user scrollable. The first part of that spec section refers to CSS properties that "specify whether a box’s content (including any ink overflow) is clipped to its padding edge". I've updated the language to specify that IntersectionObserver will apply any padding edge clip mandated by that spec section. |
Hmm, how so? |
Here's the first line in that section of the spec: "These properties specify whether a box’s content (including any ink overflow) is clipped to its padding edge, and if so, whether it is a scroll container that allows the user to scroll clipped parts of its scrollable overflow area into view." So, "scroll container" is a subset of elements that have their content clipped to the padding edge; specifically, it refers to those elements that are user-scrollable. For IntersectionObserver, we want to apply the padding edge clip to the superset, including overflow:hidden and overflow:clip. |
|
I think that's a bug in the css spec fwiw. |
SHA: a07cd7d Reason: push, by @szager-chromium Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Issue#351
Preview | Diff
Preview | Diff