Fix thresholds definition to match browsers. #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-platform-tests/wpt@8c0296b tested that thresholds when provided empty is [0]. This is not in the spec, but is reasonable and I'm happy to change Firefox to match this, given both WebKit and Blink do that.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 3, 2023
…. r=smaug Technically a broken test, but given other browsers' behavior and that having no thresholds is useless, I don't think this edge-case is worth fighting about. See w3c/IntersectionObserver#516 for the spec change. Differential Revision: https://phabricator.services.mozilla.com/D189764
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Oct 5, 2023
…. r=smaug Technically a broken test, but given other browsers' behavior and that having no thresholds is useless, I don't think this edge-case is worth fighting about. See w3c/IntersectionObserver#516 for the spec change. Differential Revision: https://phabricator.services.mozilla.com/D189764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-platform-tests/wpt@8c0296b tested that thresholds when provided empty is [0].
This is not in the spec, but is reasonable and I'm happy to change Firefox to match this, given both WebKit and Blink do that.
The following tasks have been completed:
Implementation commitment:
Preview | Diff